Skip to content

Conversation

montekki
Copy link
Member

Now that #145 is merged combinators can follow.

  1. All combinators taking &mut self should imply Self: Pin.
  2. Trait bounds are to Stream
  3. Cleans up docs and Debug derives.

Unverified

This user has not yet uploaded their public signing key.
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how this removes a lot of the pin projections; this is great!

@yoshuawuyts
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Sep 13, 2019
Merge #184

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
184: housekeeping after 145 r=yoshuawuyts a=montekki

Now that #145 is merged combinators can follow.
1. All combinators taking `&mut self` should imply `Self: Pin`.
2. Trait bounds are to `Stream`
3. Cleans up docs and `Debug` derives.

Co-authored-by: Fedor Sakharov <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 13, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 18428d6 into async-rs:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants